phpBB Forum
 
It is currently Sun Feb 26, 2017 12:21 am




Post new topic Reply to topic  [ 6 posts ] 
Small Skeleton King Issue 
Author Message
HH Donor
HH Donor

Joined: Mon Jul 29, 2013 2:52 pm
Posts: 207
Location: 伦敦
STEAM_0:0:49250027
MCID: AdvancedCori
Post Small Skeleton King Issue
There's a minor problem with skeleton king's life loss that causes players to still get damage from goombas and backstabs. This happens as the condition TF_UberchargedHidden is applied rather than TF_Ubercharged. And in the code for both the Goomba plugin and FF2 v1.0.8 (the closest version I could find for here), there are no checks for if the client has that condition as far as I can tell.

To fix it I could suggest changing TF_UberchargedHidden to TF_Ubercharged at line 103 in skeleton king's plugin (skeleton_king.sp).


Fri Apr 15, 2016 7:19 pm
Profile E-mail
HH Donor
HH Donor
User avatar

Joined: Wed Sep 04, 2013 11:06 am
Posts: 90
Location: Lost in Spaaaace
STEAM_0:0:59574366
MCID: nitros12
Post Re: Small Skeleton King Issue
This would cause the uber effect to be applied to his model, it would be a better idea to add the checks for TFCond_UberchargedCanteen (for phlog pyros in mmph state, hales can weighdown on them to goomba repeatedly and create a large amount of particles) and TFCond_UberchargedHidden.

edits would be:

Code:
line 177 of goomba_tf:
if((GetConVarBool(g_Cvar_UberImun) && TF2_IsPlayerInCondition(victim, TFCond_Ubercharged)))

replace with:

if((GetConVarBool(g_Cvar_UberImun) && (TF2_IsPlayerInCondition(victim, TFCond_Ubercharged) || TF2_IsPlayerInCondition(victim, TFCond_UberchargedCanteen) || TF2_IsPlayerInCondition(victim, TFCond_UberchargedHidden))))


FF2 in public Action:OnTakeDamage:

replace:

if(TF2_IsPlayerInCondition(client, TFCond_Ubercharged))

with:

if(TF2_IsPlayerInCondition(client, TFCond_Ubercharged) || TF2_IsPlayerInCondition(client, TFCond_UberchargedCanteen) || TF2_IsPlayerInCondition(client, TFCond_UberchargedHidden))



Fri Apr 15, 2016 7:37 pm
Profile E-mail
HH Donor
HH Donor

Joined: Mon Jul 29, 2013 2:52 pm
Posts: 207
Location: 伦敦
STEAM_0:0:49250027
MCID: AdvancedCori
Post Re: Small Skeleton King Issue
IMO, that's a bit messy having to include different types of ubercharge (where there might also be other edge cases) for plugins that might change in the future. And sacrificing some minor aesthetics that actually fit okay with the animation is worth it.


Fri Apr 15, 2016 8:00 pm
Profile E-mail
HH Donor
HH Donor
User avatar

Joined: Wed Nov 14, 2012 9:35 pm
Posts: 304
STEAM_0:1:33796966
MCID: EpicSavanah
Post Re: Small Skeleton King Issue
nitros12 wrote:
This would cause the uber effect to be applied to his model


No it wouldn't, a model need's relevant Uber skins made for it for Uber to show on the model, see the many bosses there are that gain ubercharge on rage, but don't show it.

_________________
frog wrote:
Fluffy wrote:
"Running Around On Whatever Map Happens To Be On And Doing What I Please: The Interactive Past-Time"®.
Ah so that's the name of game that's being played half of the time on HH4.


Fri Apr 15, 2016 9:41 pm
Profile E-mail
HH Donor
HH Donor

Joined: Mon Jul 29, 2013 2:52 pm
Posts: 207
Location: 伦敦
STEAM_0:0:49250027
MCID: AdvancedCori
Post Re: Small Skeleton King Issue
Yeah, that's true however this boss does have an uber model. But the thing is, it fits really well with his life loss animation. Hence, replacing the hidden uber with normal uber without the expense of extra code is good.


Sat Apr 16, 2016 11:57 am
Profile E-mail
HH Donor
HH Donor
User avatar

Joined: Wed Sep 04, 2013 11:06 am
Posts: 90
Location: Lost in Spaaaace
STEAM_0:0:59574366
MCID: nitros12
Post Re: Small Skeleton King Issue
Ah, yeah. The uber gets applied during his rage, I don't know how it would work with the tombstone model though.


Sat Apr 16, 2016 12:38 pm
Profile E-mail
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 6 posts ] 


Who is online

Users browsing this forum: No registered users and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB © phpBB Group.
Designed by Vjacheslav Trushkin for Free Forum/DivisionCore.